OCPBUGS-91759: Rebase v1.34.9 in release-4.21#2702
Conversation
Thread the reconciler's existing isRemount signal into MounterArgs so volume plugins can distinguish an initial publish from a republish (e.g. CSIDriver.spec.requiresRepublish=true). No behavior change.
On a remount (e.g. CSIDriver.spec.requiresRepublish=true), the volume is already published and the pod is observing the existing bind mount. Removing the mount dir on a NodePublish error left the pod with stale contents that subsequent successful republishes could not repair.
Accessing svc.Spec.IPFamilies[0] without a bounds check panics when a service reaches the controller with an empty IPFamilies field. This can happen via watch events: the apiserver's defaultOnRead decorator populates IPFamilies on GET/LIST but not on watch (cachingObject wrapping bypasses the type assertion). Restore the inference logic removed in kubernetes#130101: fall back to ClusterIP for headful services and pod IP for headless services. Signed-off-by: Rahul <rahulbabu95@gmail.com>
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
[1.34] Restore ability to plumb binary data through envvar values
…ck-of-#139045-upstream-release-1.34 Automated cherry pick of kubernetes#139045: fix(csi): preserve mount dir when NodePublish fails on a remount
…y-pick-of-#138736-upstream-release-1.34 Automated cherry pick of kubernetes#138736: fix: avoid panic on services with empty IPFamilies
…-pick-of-#139339-upstream-release-1.34 Automated cherry pick of kubernetes#139339: kubeadm: fix dry-run CA copy paths in init certs
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
…l134 [release-1.34] [go]Bump images and versions to go 1.25.11 and distroless iptables
Kubernetes official release v1.34.9
openshift-ci-robot
added
backports/unvalidated-commits
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-91759, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@redhat-chai-bot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/jira refresh |
|
@dusk125: This pull request references Jira Issue OCPBUGS-91759, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@redhat-chai-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dusk125, jacobsee, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/jira refresh |
|
@JSampsonIV: This pull request references Jira Issue OCPBUGS-91759, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
openshift-ci
Bot
added
backport-risk-assessed
openshift-ci
Bot
removed
the
jira/invalid-bug
openshift-ci
Bot
removed
the
backports/unvalidated-commits
openshift-ci-robot
added
the
verified
|
@jubittajohn: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
Bot
merged commit 72d01d1
into
openshift:release-4.21
|
@redhat-chai-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-91759 Jira Issue OCPBUGS-91759 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
15 participants
CHANGELOG https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.34.md#v1349